SkeletonView does not disappear properly
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 12.9k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Description
⚠️ Please fill out this template when filing an issue.
What did you do?
I am using compositional layout collection view (might be related). I have made the whole view hierarchy isSkeletonable = true. I use collectionView.showAnimatedSkeleton() to make skeleton view appear and indeed that works correctly.
Then after a while I call collectionView.hideSkeleton() on the main thread to make skeleton view disappear.
What did you expect to happen?
Skeleton view should disappear and my normal cells should appear.
What happened instead?
Skeleton view partially disappears, some labels are still masked. The whole screen is scrollable (it is bounding) when it should not be.
Steps to reproduce the behavior
described above
SkeletonView Environment
**SkeletonView version: 1.8.2
Xcode version: 11.3.1
Swift version: 5.1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the reported compositional-layout collection view using showAnimatedSkeleton() and hideSkeleton() on the main thread. Inspect the SkeletonView behavior around those entry points and verify that all masked labels disappear and the collection view no longer has unintended scroll bounds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, swift
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100