Swift Syntax
Open
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 53
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
Looks great!
Just had some quick thoughts when looking it over:
- Would turn both of these into
guard let delegate = delegate else { return }. Perfect use for guards
- After quick look over I thought you could include these 2 statements into one guard. AKA
guard !self.handledMilestones.contains(milestone), value >= milestone else { return }. Also, not sure if you need a return or continue...
Anyways, looks great man!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in Counter/Classes/Counter.swift around lines 102-117 and review the linked statements. Check whether the suggested guard changes preserve the intended return or continue behavior. Done means the syntax suggestions are addressed and the resulting control flow is confirmed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100