JsCommunity / JsCommunity/hashy
Invalid handling of pwds longer than 72 chars with Blowfish
Open
Nobody has claimed this yet.
bug
help wanted
- Dominant language
- JavaScript
- Stars
- 8
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Blowfish ignore characters after the 72nd which can cause some issues.
Actual (invalid) behavior:
> hashy <72 'x'>
<hashed password>
> hashy <72 'x' + anything> <hashed password>
ok
Expected behavior:
> hashy <72 'x' + anything> <hashed password>
not ok
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the two hashy command examples from the issue with a 72-character password and with extra characters appended. Trace where Blowfish password hashing is invoked, then verify that the longer input no longer produces the same accepted result and add coverage for both cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- authentication, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100