Joystream / Joystream/joystream

Download timeouts - use deadline in addition to response timeout

Open
#5,053 0 comments 0 reactions 0 assignees View on GitHub
argus colossus
Dominant language
Rust
Stars
1.4k
Forks
116
PR merge metrics
No merged PRs in 30d

Description

We use superagent package to fetch assets from remote nodes.
Currently we pass a single timeout value when we consider the download failed, or want to stop processing a task.
This timeout is the "deadline" timeout, but we should also use the "response" timeout to more quickly determine a download is going to be slow and move to download from the next source.

See: https://github.com/ladjs/superagent/blob/master/docs/index.md#timeouts

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.