Joystream / Joystream/joystream

CI check detecting old extrinsic weights

Open
#4,617 0 comments 0 reactions 0 assignees View on GitHub
devops runtime
Dominant language
Rust
Stars
1.4k
Forks
116
PR merge metrics
No merged PRs in 30d

Description

# Background

Currently, it may unfortunately be very easy to do a change to a codepath for one or more extrinsic, postpone updating benchmarks, and then at a much later time forget to update benchmarks for one or more extrinsics. Having some way to detect this would be very beneficial.

# Proposal

Integrate a script into the CI which reviews the diff between target and source branch, identifies all extrinsics affected by a change (not trivial), and then checks if weight is also updated. Perhaps there is some other easier way, but seems like some solution is needed here.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.