Joystream / Joystream/joystream
LOW_7: All the extrinsics have a default weight value
Open
Nobody has claimed this yet.
audit-3-findings
content-pallet
- Dominant language
- Rust
- Stars
- 1.4k
- Forks
- 116
- PR merge metrics
- No merged PRs in 30d
Description
Finding
None of the extrinsics of this pallet are benchmarked and a default weight of 10.000.000 has been set. The Joystream is encouraged to address this issue before actually using this pallet in a production runtime.
Analysis
Proper benchmarks were planned for later.
Conclusion
Add proper benchmarks: https://github.com/Joystream/joystream/issues/3221
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue does not name a pallet file or test. Start by reviewing the pallet's extrinsics and the benchmark work tracked in issue #3221; done means all extrinsics have proper benchmark-derived weights instead of the default value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- blockchain
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100