Joystream / Joystream/joystream
MEDIUM_4: The `new_data_size_fee` parameter is not bounded
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.4k
- Forks
- 116
- PR merge metrics
- No merged PRs in 30d
Description
Finding
This extrinsic updates the data size fee. There is no check on the new value set. A sudden change to a too high or too low value might bring potential issues depending on how this value is used in the system. It is recommended to set minimum and maximum values in order to avoid unexpected situations.
Analysis
https://github.com/Joystream/joystream/issues/3824
Proposal
Add min max bounds, but not urgent.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the extrinsic that updates the new_data_size_fee parameter and read the linked analysis issue #3824 for context. Determine appropriate minimum and maximum bounds, then verify that values outside them are rejected without disrupting valid updates.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100