QuarsLab Assessment Review

Some general points

• MEDIUM_1 - update substrate and old dependencies
  Updating to newer version of substrate is certainly in the roadmap for carthage and mainnet - https://github.com/Joystream/joystream/issues/3487
  We could also bump versions of substrate dependencies with cargo-update
  Perhaps we can add cargo audit step to our CI checks - as an informative check
• INFO_1 - #[transactional] I believe this will be available in substrate v3+ so we should certainly make use of it
• 5.1.3 Benchmarking - We certainly have made progress here but still many pallets are incomplete.
  • Currently we have a github action that builds runtime with benchmarks features and generates weights. This happens on every PR. It takes several hours and always times out. We should re-visit this. It doesn't make sense to generate weights on every PR. Instead this should be a manual invocation that generates and checks in the newly generated weights. It should also be performed on the "reference" hardware.
• LOW_8 - content::delete_post - extrinsic does not exist
• INFO_8 - content::create_post - extrinsic does not exit

Start with .github/workflows/joystream-node.yml and the assessment points concerning Substrate dependencies, transactional support, benchmarking, and the content extrinsics. The scope is currently a collection of separate tasks; done would require defining and completing the selected dependency, CI benchmarking, and pallet changes rather than addressing a single specified edit.