Joystream / Joystream/joystream
Split common::Trait to separate traits.
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.4k
- Forks
- 116
- PR merge metrics
- No merged PRs in 30d
Description
common::Trait is a dependency for multiple modules. We get this dependency only for modules that need membership binding and/or working group. For example, the forum user cannot be a non-member because we check their rights to act in the forum using the working group.
We could refactor common::Trait and split it into two separate traits - MembershipBound (with MemberId defined) and ActorBound (with ActorId defined) to separate the need for membership from the need of the working group for pallets.
┆Issue is synchronized with this Asana task by Unito
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating common::Trait and the modules that depend on it, especially the forum user example mentioned in the issue. Trace whether each dependency needs membership binding, working group access, or both; done means the common trait is separated into MembershipBound and ActorBound and affected modules use the appropriate trait.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- blockchain
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100