Joystream / Joystream/joystream
Changing generated weight signature means we can't benchmark FRAME's pallets
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.4k
- Forks
- 116
- PR merge metrics
- No merged PRs in 30d
Description
When benchmarking the pallets the generated weights might change signature when the adjusting function detects that a parameter can be ignored.
This means that some of the generated weights might not respect the signature of the generated function might not respect the trait. This is not a problem with our pallets because we can adjust the weight trait, however the same can't be said for FRAME's pallets.
This problem is addressed in this FRAME PR. Meaning we should update to a version that includes that PR as soon as possible.
Meanwhile, we can disable the benchmarking in our runtime for the following pallets:
frame_systempallet_timestamp
┆Issue is synchronized with this Asana task by Unito
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by checking the runtime benchmarking configuration for the frame_system and pallet_timestamp pallets, then inspect the dependency version against FRAME PR 7233. Update to a version containing that fix, or disable benchmarking for those pallets as described. Done means generated weight signatures respect the pallet traits and FRAME pallet benchmarking works.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- blockchain, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100