Joystream / Joystream/joystream

Replace GovernanceCurrency with pallet_balances type.

Open
#1,859 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

tech-debt
Dominant language
Rust
Stars
1.4k
Forks
116
PR merge metrics
No merged PRs in 30d

Description

GovernanceCurrency is an obsolete type from the common module:

  • pallet_balances supports multiple instances and we don't need a separate abstraction for this
  • we don't plan to use multiple currencies in our system in the nearest future

Removing this type allows us to simplify the type system and to remove BalanceOfX duplicates across the system.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the repository for GovernanceCurrency and BalanceOfX, then read their definitions and uses in the common module. Trace the pallet_balances type through each occurrence before removing the obsolete abstraction. Done means the duplicate types and GovernanceCurrency are gone while the system still uses the pallet_balances type consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
blockchain
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.