Joystream / Joystream/joystream

[Content curation working group] Opening immediately deactivated when entering review period

Open
#127 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Rust
Stars
1.4k
Forks
116
PR merge metrics
No merged PRs in 30d

Description

Note: this was replicated using PR #103, which may be outdated. All calls are assumed to be via polkadot.js via Pioneer

Problem

When I begin the applicant review for an opening, the opening is immediately deactivated.

Steps to reproduce
  1. Create a new curator opening. I'm setting it active at the current block, with a max review length of 99999, rationing policy of max_active_applicants: 10. There are no required stakes. This extrnsic is resolved successfully.
  2. (optional) Make a curator application. The application is stored properly, and recorded against both the Opening and the CuratorOpening.
  3. Call begin_curation_applicant_review, passing the ID of the opening created in step 1. This extrnsic is resolved successfully.
  4. Check the status of the opening; it is deactivated. Example status dump from polkadot:

screenshot

What I should see

The opening should be in a review state, not a deactivated state.

Analysis

Deactivation cause 3 seems to be review period expired... but as far as I can tell, the review period has not expired.

┆Issue is synchronized with this Asana task by Unito

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in substrate-hiring-module/src/hiring/opening.rs at the deactivation cause 3 referenced by the issue, then reproduce the flow through begin_curation_applicant_review using polkadot.js via Pioneer. Compare the opening status before and after review begins and confirm that a valid review-period opening remains in review rather than becoming deactivated.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
blockchain
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.