Joy-of-Coding / Joy-of-Coding/ReactJam_2025_Spring

How to do peer review

Open
#58 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2
Forks
1
PR merge metrics
No merged PRs in 30d

Description

How to do Peer Review for ReactJam_2025_Spring
Starting from this Board https://github.com/orgs/Joy-of-Coding/projects/4/views/1

Go to the "Peer Review" column. If there are items there, "Pull requests" appears at the top of the page.

If ticket wants 'Peer Review' and there is no Pull Request:
You will have to make a pull request for that ticket. NOTE: You will not be able to approve the ticket if you do this.
Better to have the Dev do the pull request before you proceed with the review

Go to Pull requests

Click ticket item...for example “Added car component…#57”

Look at the whole page. If you see 'This branch has conflicts that must be resolved'
You can either try to resolve the conflict or refer it to Katrina and note this in comments.
Otherwise if no conflicts:

Copy the blue highlighted text by clicking the two small double boxes.

Leave page and go to your IDE (VS, Pycharm)

At IDE, go to terminal and type:
git fetch
git pull
git checkout [Paste the highlighted text that you copied in step 4]
Enter
npm run dev

#if you don’t have [node.js](http://node.js/),
#type npm install dev

You will get the rune QR code and 2 links which appear above it.
Click Local: http//localhost:5173/
RUN THE CODE TO SEE IF IT WORKS

Go back to github.

At github, click the red ‘Review’ button. (---above the red ‘Merging is blocked’ button).

Click the “Files changed” tab.
Review the changes:
Red = deleted
Blue = existing
Green = added
Look for anything out of place or unusual.

Click the green ‘Review Changes” button.
Select one of the following:
Comment
Approve
Request Changes

Click the green “Submit review” button. (and follow the other buttons to 'Merge' and 'Confirm Merge')

Contributor guide

No contributing guide indexed for this repository

Research direction

Use the issue body as the source for the peer-review procedure, and first identify where this project keeps contributor or process documentation; no target file is named. Done means the steps, commands, review choices, and local-run instructions are available there and accurately describe the workflow.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, javascript, node.js
Domain
documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.