JoshuaKGoldberg / JoshuaKGoldberg/create-typescript-app
🛠 Tooling: Add an app or workflow that adds 'status: waiting for author' when a PR review is submitted
- Dominant language
- TypeScript
- Stars
- 1.4k
- Forks
- 89
- Avg merge
- 1m
- Merged PRs (30d)
- 3
Description
### Bug Report Checklist
- [X] I have tried restarting my IDE and the issue persists.
- [X] I have pulled the latest `main` branch of the repository.
- [X] I have [searched for related issues](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aissue) and found none that matched my issue.
### Overview
#312 -> #632 saw this repo add a `.github/workflows/pr-review-requested.yml` workflow. That workflow removes the `status: waiting for author` label when a PR review is requested. Removing the label automatically is useful because external contributors generally don't have permissions do to it themselves.
Another part of #312 I'd hoped to do is the reverse: when a PR review is submitted, _add_ the `status: waiting for author` label. But I wasn't able to do that in #632 because https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target doesn't include a `review_submitted` event.
Per https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull-request-events-for-forked-repositories-1 I would have thought `pull_request_review` would be able to run from the base repo for PRs from forks. But in testing I couldn't get that to work.
If someone can add a workflow, or GitHub app, or Danger script (#445), and can show it running on a PR from a fork to a repo, that'd be lovely.
### Additional Info
https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/28ba2da620adddf84c0b711df02959f5d6ac1a27/.github/workflows/pr-review-submitted.yml shows what I would have liked for the workflow.
Contributor guide
Assessment
This issue has not been assessed yet.