JoshuaKGoldberg / JoshuaKGoldberg/TypeStat

Bug: missing semi-colon after object member

Open
#2,017 3 comments 1 reaction 0 assignees View on GitHub
area: fixers area: react status: accepting prs type: bug
Dominant language
TypeScript
Stars
2.3k
Forks
47
Avg merge
15h 55m
Merged PRs (30d)
21

Description

### 🐛 Bug Report

- TypeStat version: 0.8.1
- TypeScript version: 5.2
- Node version: 20

#### Actual Behavior

```patch
diff --git a/lib/ReactViews/Custom/Chart/ChartPanelDownloadButton.tsx b/lib/ReactViews/Custom/Chart/ChartPanelDownloadButton.tsx
index 20bb45d24..ba40adf73 100644
--- a/lib/ReactViews/Custom/Chart/ChartPanelDownloadButton.tsx
+++ b/lib/ReactViews/Custom/Chart/ChartPanelDownloadButton.tsx
@@ -86,7 +86,15 @@ async function download(items: TableMixin.Instance[]) {
}

export const ChartPanelDownloadButton = observer(
- (props: { chartableItems: ChartableMixin.Instance[] }) => {
+ (props: { chartableItems: ChartableMixin.Instance[] key: string;
+catalogItem: MappableMixin.Instance;
+features: TerriaFeature[];
+onToggleOpen: (feature: TerriaFeature) => void;
+viewState: ViewState;
+item: CatalogMemberMixin.Instance;
+removable: boolean;
+terria: Terria;
+}) => {
// For the moment we only support TableMixin items
const tableItems = props.chartableItems.filter(TableMixin.isMixedInto);
```

#### Expected Behavior

Just looking at the output, I would guess that TypeStat forgets to add a semi-colon and/or newline after the single member of the object when there isn't one, and proceeds to output its discovered additional members.

#### Reproduction

Same as #2014.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.