JoshuaKGoldberg / JoshuaKGoldberg/TypeStat

Add format:verify back to GitHub Actions push.yml

Open
#1,017 0 comments 0 reactions 0 assignees View on GitHub
area: tooling status: accepting prs
Dominant language
TypeScript
Stars
2.3k
Forks
47
Avg merge
15h 55m
Merged PRs (30d)
21

Description

I removed it from https://github.com/JoshuaKGoldberg/TypeStat/pull/1011 because it constantly complained about at least one file being off in a way I couldn't figure out. Annoying.

https://github.com/JoshuaKGoldberg/TypeStat/runs/4129272214?check_suite_focus=true

```
$ yarn prettier --list-different "**/*.{js,json,md,ts,yml}"
$ /home/runner/work/TypeStat/TypeStat/node_modules/.bin/prettier --list-different '**/*.{js,json,md,ts,yml}'
src/mutations/typeMutating/createNonNullAssertion.ts
error Command failed with exit code 1.
```

Contributor guide

Open the contributing guide

Research direction

Start in push.yml and review the removed format:verify step alongside the linked GitHub Actions run. Run the reported yarn prettier --list-different command and inspect src/mutations/typeMutating/createNonNullAssertion.ts. Done means the verification step is restored and the push workflow no longer fails on the reported formatting difference.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, typescript
Domain
ci-cd
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.