Joseph-Ramon-Lucas / Joseph-Ramon-Lucas/PennyPincher

Future CashflowEntryController updates

Open
#35 0 comments 0 reactions 0 assignees View on GitHub
help wanted question
Dominant language
C#
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

- After updating a new cashflow entry insert, the order id starts at 1 after the dummy data is loaded, should we expect/want this behavior? (UPDATE: Actually I need to investigate this behavior again but has to do with either create or update)

- I do not see the point of having partial update and complete update endpoints when we both have to manually map property names for new assigned values. I read online for suggestions to do some sort of automapping custom class method for the complete update endpoint method. I will look into this

- Perhaps instead of having an entry_date field for the CashflowEntry models, we should have a last_updated field that encapuslates both the business logic of an update for when a CashflowEntry is first entered and also when it is edited/updated

- Having a separate property CategoryTypeAsString may be unnecessary because we can just

`return cashflowEntry.categoryType.ToString()` instead of `return cashflowEntry.categoryTypeAsString`.

Could be developer preference however. I did not update this because this is being used in `AnalysisController.cs`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.