JetBrains / JetBrains/resharper-unity

Wrong suggestions for EditorTool

Open
#1,722 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
1.2k
Forks
142
PR merge metrics
No merged PRs in 30d

Description

I dropped `CurrentData` in an `EditorTool`, though conditional is wrong and I didn't fix it yet, R# suggests two totally irrelevant suggestions for it:

![devenv_2020-07-01_01-12-14](https://user-images.githubusercontent.com/1537591/86185943-eeaafc80-bb37-11ea-9bc1-c8793bec4efd.png)

Even if code is somewhat better, they still show;

![devenv_2020-07-01_01-16-10](https://user-images.githubusercontent.com/1537591/86186110-7ee94180-bb38-11ea-822b-880713b4c440.png)

Finally, _Use null propagation_ is also irrelevant:

![devenv_2020-07-01_01-20-31](https://user-images.githubusercontent.com/1537591/86186326-19498500-bb39-11ea-9272-caa82f49bb46.png)

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the reported CurrentData and EditorTool cases in ReSharper or Rider, including the conditional and null-propagation examples shown in the screenshots. Trace which suggestions are offered for these cases and adjust the relevant inspection behavior so irrelevant suggestions are no longer displayed.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, unity
Domain
game-dev, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.