JetBrains / JetBrains/resharper-unity

Coroutines are marked as performance critical context

Open
#1,395 13 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
1.2k
Forks
142
PR merge metrics
No merged PRs in 30d

Description

Almost all coroutines are marked as performance critical context. Often this does not seem justified. E.g.:
```
// Called from Start()
private IEnumerator PlaySoundSequence()
{
yield return new WaitForSeconds(delay);
PlaySound(sound);
}
```
Seemingly randomly some are not marked. What's the pattern here? Should this be the case?

Contributor guide

Open the contributing guide

Research direction

Use the PlaySoundSequence coroutine called from Start() as the reproduction case, and compare it with coroutines that are not marked as performance-critical. Determine the rule behind the differing annotations and whether the example is incorrectly classified. Done means the behavior is explained and any required correction is covered by a reproducible check.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, unity
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.