JetBrains / JetBrains/resharper-fsharp

Show active build status in readme

Open
#490 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
F#
Stars
351
Forks
55
Avg merge
9h 38m
Merged PRs (30d)
16

Description

Hello,

I just synced my fork and can no longer build my ReSharper.FSharp.sln.

See errors 
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\AnonModulePart.cs(8,18):
 error CS0534: 'AnonModulePart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypeP
arameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\EnumPart.cs(9,18): error
 CS0534: 'EnumPart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypeParameter(int
)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\DelegatePart.cs(18,18):
error CS0534: 'DelegatePart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypePara
meter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\ClassPart.cs(12,18): err
or CS0534: 'ClassPart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypeParameter(
int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\ExceptionPart.cs(15,18):
 error CS0534: 'ExceptionPart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypePa
rameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\DeclaredElement\FSharpTypeParameterOf
Method.cs(18,75): error CS0535: 'FSharpTypeParameterOfMethod' does not implement interface member 'ITypeParameter.Nulla
bleAnnotation' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\HiddenTypePart.cs(12,18)
: error CS0534: 'HiddenTypePart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForType
Parameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\InterfacePart.cs(8,18):
error CS0534: 'InterfacePart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypePar
ameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\NestedModulePart.cs(7,18
): error CS0534: 'NestedModulePart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForT
ypeParameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\NamedModulePart.cs(7,18)
: error CS0534: 'NamedModulePart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTyp
eParameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\ObjectExpressionTypePart
.cs(13,16): error CS0534: 'ObjectExpressionTypePart' does not implement inherited abstract member 'TypePart.IsNullableC
ontextEnabledForTypeParameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Ps
i.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\RecordPart.cs(15,18): er
ror CS0534: 'RecordPart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypeParamete
r(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\RecordPart.cs(33,18): er
ror CS0534: 'StructRecordPart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypePa
rameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\StructPart.cs(8,18): err
or CS0534: 'StructPart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypeParameter
(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\TypeExtensionParts.cs(11
,18): error CS0534: 'ClassExtensionPart' does not implement inherited abstract member 'TypePart.IsNullableContextEnable
dForTypeParameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\TypeExtensionParts.cs(32
,18): error CS0534: 'StructExtensionPart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabl
edForTypeParameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\TypeAbbreviationOrDeclar
ationPart.cs(10,18): error CS0534: 'TypeAbbreviationOrDeclarationPart' does not implement inherited abstract member 'Ty
pePart.IsNullableContextEnabledForTypeParameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FS
harp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\TypeAbbreviationOrDeclar
ationPart.cs(26,18): error CS0534: 'StructTypeAbbreviationOrDeclarationPart' does not implement inherited abstract memb
er 'TypePart.IsNullableContextEnabledForTypeParameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\
src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\UnionPart.cs(31,18): err
or CS0534: 'StructUnionPart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypePara
meter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\UnionCasePart.cs(12,18):
 error CS0534: 'UnionCasePart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypePa
rameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\UnionPart.cs(13,18): err
or CS0534: 'UnionPart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypeParameter(
int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
    393 Warning(s)
    21 Error(s)

This could mean two things:

  • There is an actual problem with the net231 branch here.
  • Something locally isn't working out due to some caching.

It would be great if I could go to the home page of this repository and see if the current branch is indeed building correctly.
I guess some workflow very similar to .github\workflows\ci.yml would suffice where the code is built every time there is a commit. (Maybe skip running the tests, I don't know about that).
Once this is set up a badge could be displayed from https://shields.io/category/build in the ReadMe.

Does this sound sensible?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading .github/workflows/ci.yml and the repository README, then inspect how ReSharper.FSharp.sln is built in the reported net231 context. Define the workflow's successful build result and the README badge as the completion criteria; consider whether tests should be included as the issue suggests.

Written by the indexing model from the issue text.

Assessment

Tech stack
fsharp, github-actions
Domain
ci-cd, documentation
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.