JessYanCoding / JessYanCoding/InsGallery

Incorrect argument pass in method takePicture() of CameraView class in InstagramCameraView.java

Open
#29 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
673
Forks
127
PR merge metrics
No merged PRs in 30d

Description

Required ImageCapture.OutputFileOptions type, but provided File type.

//InstagramCameraView.java

mCaptureLayout.setCaptureListener(new InstagramCaptureListener() {
@Override
public void takePictures() {
if (mCameraView == null) {
return;
}
mCameraView.setCaptureMode(androidx.camera.view.CameraView.CaptureMode.IMAGE);
File imageOutFile = createImageFile();
//this line is missing in maven lib version
//ImageCapture.OutputFileOptions options = new ImageCapture.OutputFileOptions.Builder(imageOutFile).build();
ImageCapture.OutputFileOptions options = new ImageCapture.OutputFileOptions.Builder(imageOutFile).build();
mCameraView.takePicture(options, ContextCompat.getMainExecutor(getContext().getApplicationContext()), new OnImageSavedCallbackImpl(InstagramCameraView.this, imageOutFile));
}
//...
});

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.