JedWatson / JedWatson/react-select

MenuPortal placement is off for position='fixed' if a parent has transform: scale

Open
#5,846 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

issue/bug-unconfirmed
Dominant language
TypeScript
Stars
28k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

Bug description

For a menu inside a scaled div, the top and left properties on MenuPortal styles are calculated based on the viewport instead of based on the "containing block", which is the scaled div.

Fixed positioning is similar to absolute positioning, with the exception that the element's containing block is the initial containing block established by the viewport, unless any ancestor has transform, perspective, or filter property set to something other than none (see CSS Transforms Spec), which then causes that ancestor to take the place of the elements containing block.
https://developer.mozilla.org/en-US/docs/Web/CSS/position#fixed_positioning

This causes the menuportal to be displayed to the bottom-right of where it should be:
Screenshot 2024-01-11 at 12 09 10 PM

The issue is simple to reproduce by placing a ReactSelect component inside of a div with a transform: scale style.

import React from "react";
import ReactDOM from "react-dom";

import ReactSelect from "react-select";

function Selection() {
  return (
    <ReactSelect
      menuPosition="fixed"
      options={[
        {
          label: "hi",
          value: "hi",
        },
        {
          label: "bye",
          value: "bye",
        },
      ]}
    />
  );
}

function FixedBox({ children }: { children: React.ReactNode }) {
  return (
    <div
      style={{
        margin: 100,
        border: "1px solid black",
        transform: "scale(1)",
      }}
    >
      <h1>fixed container</h1>
      {children}
    </div>
  );
}

function Example() {
  return (
    <FixedBox>
      <Selection />
    </FixedBox>
  );
}

ReactDOM.render(<Example />, document.getElementById("root"));

sandbox link

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the MenuPortal placement logic and reproduce the issue with the provided scaled div and sandbox. Verify the menu's top and left coordinates against its transformed containing block; done means fixed-position menus align correctly when an ancestor uses transform: scale.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.