JedWatson / JedWatson/react-select
closeMenuOnScroll not working
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 28k
- Forks
- 4.1k
- PR merge metrics
- No merged PRs in 30d
Description
closeMenuOnScroll seems to not be working
Reproduction: https://codesandbox.io/s/codesandboxer-example-forked-wppm3h?file=/example.tsx
Debugging the code I see the following check is being done
https://github.com/JedWatson/react-select/blob/a465818786afd4857c9155bef1e9aa2fe3356097/packages/react-select/src/Select.tsx#L1281
which is not passed when scrolling as document is not an HTMLElement.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue using the linked CodeSandbox, then inspect packages/react-select/src/Select.tsx at the check around line 1281. Verify the behavior while scrolling the document and consider the issue complete when closeMenuOnScroll works for that case without breaking the existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100