JedWatson / JedWatson/react-select
closeMenuOnSelect={false} with custom ValueContainer breaks the ability to dismiss dropdown with outside click
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 28k
- Forks
- 4.1k
- PR merge metrics
- No merged PRs in 30d
Description
It seems the ability to click outside the dropdown to dismiss it will break when using a custom ValueContainer combined with closeMenuOnSelect={false}
Below is a simple sandbox highlighting the issue.
https://codesandbox.io/s/react-select-custom-valuecontainer-forked-hdv1el
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked CodeSandbox and reproduce the failure using closeMenuOnSelect={false} with a custom ValueContainer. Trace the outside-click dismissal behavior in the relevant react-select code; done means the dropdown can again be dismissed by clicking outside in that configuration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100