JedWatson / JedWatson/react-select
defaultPrevented issue with react-beautiful-dnd
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 28k
- Forks
- 4.1k
- PR merge metrics
- No merged PRs in 30d
Description
Since the following change 150c02028aa8e47f4071357e44f4c0daeda44a18
React Select can no longer be opened through onControlMouseDown and the event.defaultPrevented is always true when the component is rendered inside react-beautiful-dnd.
CSB: https://codesandbox.io/s/vertical-list-forked-mucu2g?file=/index.js
@rkulinski can you consider using internal flag instead of defaultPrevented (53cc8ce7f87ed660276361b6d89e8fb175c19ac6) to ensure that the event is captured by dropdown indicator ?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing change 150c02028aa8e47f4071357e44f4c0daeda44a18 with the earlier reference 53cc8ce7f87ed660276361b6d89e8fb175c19ac6. Reproduce the CodeSandbox case with react-beautiful-dnd and inspect the event path around onControlMouseDown and the dropdown indicator. Done means the select can open in that context without relying on an always-true defaultPrevented value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100