JedWatson / JedWatson/react-select
Remove filter buttons lacking role attribute
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 28k
- Forks
- 4.1k
- PR merge metrics
- No merged PRs in 30d
Description
My company is currently doing accessibility reviews of various front-end code. We've come across an issue where the remove filter buttons on the multiselect lack the role attribute. Would it be possible for this to be added? It would be for the individual filters as well as the remove all filters button.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the front-end multiselect implementation for the individual remove-filter buttons and the remove-all-filters button. Check how those controls are rendered and define done as adding the requested role attribute to both cases, with the relevant accessibility behavior verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100