JedWatson / JedWatson/react-select
onMenuScrollToBottom is only fired once unless we close the menu and do scroll down again
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 28k
- Forks
- 4.1k
- PR merge metrics
- No merged PRs in 30d
Description
Good evening everybody,
I'm currently using the prop onMenuScrollToBottom and this one works perfectly when opening the menu and scrolling to the bottom on the last option. However, let's say we want to keep scrolling down and therefore call the function onMenuScrollToBottom again, we can't do that unless we close the menu, open it again and go back to the last option and start scrolling, which is very frustrating for the UX
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in react-select with onMenuScrollToBottom, scrolling repeatedly without closing the menu. Trace the menu scroll behavior and add coverage showing that the callback can fire again during continued scrolling; done means repeated bottom-reaching scrolls invoke the callback without reopening the menu.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100