JayArrowz / JayArrowz/NetScape
Async Observer pattern possible future issues
- Dominant language
- C#
- Stars
- 21
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
The Message handlers currently support async functions:
.e.g.
https://github.com/JayArrowz/NetScape/blob/12f629d52d2eacf50dab96a16b14f2e211f0319a/NetScape.Modules.FourSevenFour.Game/Messages/Handlers/WelcomeScreenHandler.cs#L22
However if anything modifies the world state in a async manner and is not thread safe it could cause issues.
Anything executed in the message handlers has to be thread safe.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with the async handler example in NetScape.Modules.FourSevenFour.Game/Messages/Handlers/WelcomeScreenHandler.cs and trace how message handlers modify world state. The issue does not identify a specific unsafe operation or desired implementation; done would require a defined thread-safety approach and corresponding coverage for async handlers.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100