JavaWebStack / JavaWebStack/orm
Immutable Query objects
@JanHolger is already working on this.
Since Sep 13, 2023.
- Dominant language
- Java
- Stars
- 7
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Is your feature request related to a problem? Please describe.
Right now the Query and QueryGroup classes are built in a builder pattern style way (mutating their own object and returning this). This has a couple advantages but also comes with several disadvantages and I would generally say that it is bad practice.
Describe the solution you'd like
Since completely changing them to immutable may break existing code and may not be in favor of all users, I would rather add a new .mutable() and .immutable() switch and a default state for new queries in the config.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.