Jasonette / Jasonette/documentation

support file url in $network.upload

Open
#74 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
120
Forks
72
PR merge metrics
No merged PRs in 30d

Description

Currently $network.upload uses the mostly undocumented `data` property to upload a data uri to S3.
Instead, as discussed with @gliechtenstein on slack, it would be better to support using a local file url as the source of the data to be uploaded, which avoids having to hold the whole file being uploaded (which potentially can be very large) in app memory.
The syntax that will be used for the property is:
```
"data": {
"file_url": "..."
}
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the $network.upload entry point and the code that sends upload data to S3. Verify how the existing data property handles data URIs, then determine where the file_url form should be accepted and how completion can be tested without loading the whole file into app memory.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws
Domain
api, backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.