Jasonette / Jasonette/JASONETTE-iOS

REQUEST: Set border color for body.header

Open
#113 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
5.2k
Forks
347
PR merge metrics
No merged PRs in 30d

Description

A lot of apps with a header (equivalent of `body.header`) have a border along the bottom (usually light grey). Unfortunately we don't have the ability to set that colour or even make it appear.

A good example is Instagram or Chrome. The only way to replicate this border is to set a space at 1 height with a grey background... but if you have a `$pull` action in your app, the grey line is pulled down with the rest of the view, which isn't right.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name a file or test. Start by tracing how body.header is rendered and how pull actions move the view; determine where a persistent bottom border could be configured. Done means header borders can be enabled and given a color without the border being pulled with the view.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, javascript
Domain
mobile-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.