Jasonette / Jasonette/JASONETTE-Android

No URL encoding on $network.request

Open
#67 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
1.6k
Forks
266
PR merge metrics
No merged PRs in 30d

Description

I've got the following code:

`{`
"type": "$network.request",
"options": {
"url": "http://www.example.com/{{$get.field}}"
}
}`

The problem is that if the field has spaces (or other characters that need escaping) then the request seems to hang. I think $network.request should always do URL encoding.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Android implementation of the $network.request entry point and inspect how its URL is handled. Reproduce the request with a field containing spaces or other characters needing escaping; done means the request completes with a correctly encoded URL without regressing ordinary URLs.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
mobile, networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.