JanusGraph / JanusGraph/janusgraph
Closing partitionVertexIdPool when VertexIDAssigner is closed
- Dominant language
- Java
- Stars
- 5.8k
- Forks
- 1.2k
- Avg merge
- 13h 53m
- Merged PRs (30d)
- 6
Description
> One of the two threadpools opened in VertexIDAssigner is never shutdown. This came up in my case when running JMH benchmarks. At the end of the benchmarks the threads would still be around after a close was issued.
A [PR](https://github.com/JanusGraph/janusgraph/pull/667) was submitted to fix this a while back, but an issue was not created to track the problem reported. The PR was merged and then subsequently [reverted](https://github.com/JanusGraph/janusgraph/pull/810) because it was breaking the build.
Contributor guide
Research direction
Start by locating VertexIDAssigner and its close path, then inspect how partitionVertexIdPool is opened and shut down. Review PR 667 and its reversion in PR 810 for prior context, and use the JMH benchmark scenario mentioned in the issue to check for lingering threads. Done means closing VertexIDAssigner shuts down both thread pools without breaking the build.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100