JanusGraph / JanusGraph/janusgraph

Remove the workaround to access HBase convertScanToString in hbase inputformat code

Open
#837 1 comment 0 reactions 0 assignees View on GitHub
storage/hbase
Dominant language
Java
Stars
5.8k
Forks
1.2k
Avg merge
13h 53m
Merged PRs (30d)
6

Description

In the review for #707, we agree we should clean up the workaround to access HBase convertScanToString in hbase inputformat code.
```
// This is a workaround, to be removed when convertScanToString becomes public in hbase package.
Method converter;
try {
converter = TableMapReduceUtil.class.getDeclaredMethod("convertScanToString", Scan.class);
converter.setAccessible(true);
config.set(TableInputFormat.SCAN, (String) converter.invoke(null, scanner));
} catch (Exception e) {
throw new RuntimeException(e);
}
```

Contributor guide

Open the contributing guide

Research direction

Search the Java HBase input-format code for the shown reflective access to TableMapReduceUtil.convertScanToString, then inspect the HBase API entry point it is intended to replace. Done means the workaround is removed while scan conversion behavior remains unchanged. The payload names no specific file or test, so identify the relevant HBase input-format tests before changing it.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
databases
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.