JanusGraph / JanusGraph/janusgraph
replace all assert statements with Preconditions.checkState
Open
kind/cleanup
- Dominant language
- Java
- Stars
- 5.8k
- Forks
- 1.2k
- Avg merge
- 13h 53m
- Merged PRs (30d)
- 6
Description
I was bitten by an ugly bug in socialsensor/graphdb-benchmark because Titan/JG was failing silently when checking the validity of a manually-created vertex id. Actually throwing the exception will help us catch the poison pills and increase code quality.
Contributor guide
Research direction
Search the Java source for assert statements and review the surrounding validity checks before deciding which uses correspond to Preconditions.checkState. Completion means the applicable assertions are replaced with explicit checks and the existing test suite is run to identify regressions; the issue names no specific files or tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- database
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100