JanusGraph / JanusGraph/janusgraph
Support ZooKeeper client and connect timeout configuration
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 5.8k
- Forks
- 1.2k
- Avg merge
- 13h 53m
- Merged PRs (30d)
- 6
Description
The Solr index implementation currently uses default timeout (10s) in cloud mode.
https://github.com/JanusGraph/janusgraph/blob/master/janusgraph-solr/src/main/java/org/janusgraph/diskstorage/solr/SolrIndex.java#L244-L248
It would nice to have it configurable just as HTTP mode. The CloudSolrClient from solrj does support customization of both timeout:
https://lucene.apache.org/solr/5_3_0/solr-solrj/org/apache/solr/client/solrj/impl/CloudSolrClient.html#setZkConnectTimeout(int)
Experienced by other people, and suggestion to raise the default timeout value:
http://lucene.472066.n3.nabble.com/Could-not-connect-to-ZooKeeper-x-x-x-x-2181-solr-within-10000-ms-td4169634.html
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in janusgraph-solr/src/main/java/org/janusgraph/diskstorage/solr/SolrIndex.java around lines 244-248, and compare cloud-mode setup with the existing HTTP-mode timeout configuration. Check the CloudSolrClient timeout customization described in the issue, then verify that cloud-mode connections honor the configured timeout rather than the default 10 seconds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- databases
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100