JanusGraph / JanusGraph/janusgraph

Fix npe vunerabilities

Open
#52 0 comments 0 reactions 0 assignees View on GitHub
kind/bug/possible
Dominant language
Java
Stars
5.8k
Forks
1.2k
Avg merge
13h 53m
Merged PRs (30d)
6

Description

Fortify - High - can crash the program
- [x] [BasicVertexCentricQueryBuilder](https://github.com/JanusGraph/janusgraph/blob/84ead7d/janusgraph-core/src/main/java/org/janusgraph/graphdb/query/vertex/BasicVertexCentricQueryBuilder.java#L347) - Fixed in #469 (verify)
- [ ] [EdgeSerializer](https://github.com/JanusGraph/janusgraph/blob/84ead7d/janusgraph-core/src/main/java/org/janusgraph/graphdb/database/EdgeSerializer.java#L165)
- [ ] [EdgeSerializer](https://github.com/JanusGraph/janusgraph/blob/84ead7d/janusgraph-core/src/main/java/org/janusgraph/graphdb/database/EdgeSerializer.java#L173)
- [ ] [Geoshape](https://github.com/JanusGraph/janusgraph/blob/84ead7d/janusgraph-core/src/main/java/org/janusgraph/core/attribute/Geoshape.java#L444)
- [ ] [IndexHelper](https://github.com/JanusGraph/janusgraph/blob/84ead7d/janusgraph-core/src/main/java/org/janusgraph/graphdb/util/IndexHelper.java#L58)
- [x] [QueryUtil](https://github.com/JanusGraph/janusgraph/blob/84ead7d/janusgraph-core/src/main/java/org/janusgraph/graphdb/query/QueryUtil.java#L299) - Fixed in #469 (verify)
- [x] [StandardJanusGraph](https://github.com/JanusGraph/janusgraph/blob/84ead7d/janusgraph-core/src/main/java/org/janusgraph/graphdb/database/StandardJanusGraph.java#L675) - Fixed in #469 (verify)

Contributor guide

Open the contributing guide

Research direction

Start by reading the unchecked locations in EdgeSerializer.java, Geoshape.java, and IndexHelper.java, then compare the checked locations and fixes referenced in #469. Inspect each listed path for the reported null-pointer vulnerability; done means the four unchecked items are addressed and the three #469 fixes are verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
databases, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.