JanusGraph / JanusGraph/janusgraph
Update TinkerPop to 3.6.5
- Dominant language
- Java
- Stars
- 5.8k
- Forks
- 1.2k
- Avg merge
- 13h 53m
- Merged PRs (30d)
- 6
Description
**Declaimer: TinkerPop 3.6.5 is not released yet, but this issue exists to not forget make changes during the next TinkerPop upgrade.**
For TinkerPop 3.6.4 we are opting out from the TinkerPop test `org.apache.tinkerpop.gremlin.process.traversal.step.map.CountTest.g_VX1X_valuesXageX_countXlocalX` (see [comment](https://github.com/JanusGraph/janusgraph/pull/3780#issuecomment-1571961290)) because it wasn't correct in that version. However the test is already fixed in TinkerPop branch `3.6-dev` (see [commit](https://github.com/apache/tinkerpop/commit/822f652916f15be311f2f7760e5722a37813e38c)).
Thus, starting from TinkerPop 3.6.5 the test should work as expected (I checked this test with JanusGraph and it works as expected).
Thus, we should enable this test back again when we upgrade to TinkerPop version >= 3.6.5 by removing the following lines from `janusgraph-core/src/main/java/org/janusgraph/core/JanusGraph.java`:
```
@Graph.OptOut(
test = "org.apache.tinkerpop.gremlin.process.traversal.step.map.CountTest",
method = "g_VX1X_valuesXageX_countXlocalX",
reason = "TinkerPop 3.6.4 buggy test. We should remove this OptOut when updating to TinkerPop >= 3.6.5 because the test was fixed in TinkerPop 3.6.5. " +
"See comment here: https://github.com/JanusGraph/janusgraph/pull/3780#issuecomment-1571961290")
```
Those lines were are added in the PR #3780 .
Contributor guide
Research direction
Start in janusgraph-core/src/main/java/org/janusgraph/core/JanusGraph.java and review the OptOut for CountTest.g_VX1X_valuesXageX_countXlocalX. Confirm the TinkerPop upgrade reaches version 3.6.5 or later, remove the specified OptOut, and run the referenced CountTest to verify it passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100