JanusGraph / JanusGraph/janusgraph
Mark org.janusgraph.core.Cardinality as deprecated
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 5.8k
- Forks
- 1.2k
- Avg merge
- 13h 53m
- Merged PRs (30d)
- 6
Description
We should replace after some years now JanusGraph's Cardinality with the tinkerpop equivalent `VertexProperty.Cardinality`.
Todo:
* Mark org.janusgraph.core.Cardinality as deprecated.
* Mark function: cardinality(org.janusgraph.core.Cardinality cardinality) as deprecated.
* Extend `Multiplicity` by adding convert api for `VertexProperty.Cardinality` (add in 0.4.1)
* Exented `PropertyKeyMaker` by adding following function: `cardinality(VertexProperty.Cardinality cardinality)` (add in 0.4.1)
* All usage to PropertyKeyMaker.cardinality should use the new variant. (add in 0.4.1)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating org.janusgraph.core.Cardinality, its cardinality(...) function, Multiplicity, and PropertyKeyMaker, then inspect all usages of PropertyKeyMaker.cardinality. Add the deprecation markers and the VertexProperty.Cardinality conversion and overload described in the issue, updating existing usages for the 0.4.1 target. Done means the old API is deprecated and the new variant is used consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100