JanssenProject / JanssenProject/jans
feat: ignore domain filed in fido2
Open
Nobody has claimed this yet.
kind-feature
- Dominant language
- Java
- Stars
- 648
- Forks
- 174
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 110
Description
If `fido2_domain` property not specified script should use all enrolled devices except super_gluu.
To implement this we need to use `self.fido2_domain` [](https://github.com/JanssenProject/jans/blob/main/docs/script-catalog/person_authentication/fido2-external-authenticator/Fido2ExternalAuthenticator.py#L164)
For case if `self.fido2_domain` is not specified or empty we can filter result list. Script need to parse `jansRegistrationData` attribute JSON. Inside it there is `attenstationRequest` with another JSON value which has property `"super_gluu_request":true`
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.