JanssenProject / JanssenProject/jans

ci: use pinned versions in cedarling test workflow

Open
#13,866 1 comment 1 reaction 0 assignees View on GitHub
area-CI
Dominant language
Java
Stars
648
Forks
174
Avg merge
1d 18h
Merged PRs (30d)
110

Description

> _⚠️ Potential issue_ | _🟡 Minor_
>
>
> 🧩 Analysis chain
>
> 🏁 Script executed:
>
> ```shell
> #!/bin/bash
> # Description: Show Rust toolchain pins and explicit cargo toolchain overrides.
>
> echo "Repo Rust toolchain:"
> sed -n '1,20p' jans-cedarling/rust-toolchain.toml
>
> echo
> echo "Workflow Rust toolchain declarations and overrides:"
> rg -n -C2 'toolchain:\s*(stable|"1\.95\.0"|'\''1\.95\.0'\'')|cargo\s+\+(stable|1\.95\.0)|rustup component add --toolchain' .github/workflows/test-cedarling.yml
> ```
>
> Repository: JanssenProject/jans
>
> Length of output: 2607
>
> ---
>
>
>
>
>
> **Keep the Rust toolchain pin consistent across Cedarling CI.**
>
> The python_tests job correctly uses `1.95.0` (matching `jans-cedarling/rust-toolchain.toml`), but other jobs still install `stable`. Once stable advances, CI will validate different compilers depending on the job, creating inconsistent test coverage.
>
> Update all Cedarling workflow jobs to use the pinned `1.95.0` version:
> - Change `toolchain: stable` to `toolchain: "1.95.0"` in job `with:` blocks (lines 26, 59, 108, 138, 213, 250)
> - Change `cargo +stable` to `cargo +1.95.0` in run steps (lines 44, 169)
> - Change `rustup component add --toolchain stable` to `--toolchain 1.95.0` (lines 29, 142)
>
>
> 🤖 Prompt for AI Agents
>
> ```
> Verify each finding against the current code and only fix it if needed.
>
> In @.github/workflows/test-cedarling.yml around lines 192 - 195, Update all
> Cedarling workflow steps that currently use the unpinned "stable" Rust toolchain
> to the pinned version "1.95.0": replace occurrences of toolchain: stable with
> toolchain: "1.95.0" in each job's with: block, change any run steps invoking
> cargo +stable to cargo +1.95.0, and change rustup component add --toolchain
> stable to --toolchain 1.95.0 so every job (including the python_tests and other
> Cedarling jobs) uses the exact same 1.95.0 toolchain.
> ```
>
>
>
>
>
>

_Originally posted by @coderabbitai[bot] in [#13862](https://github.com/JanssenProject/jans/pull/13862/changes#r3109652210)_

Contributor guide

Open the contributing guide

Research direction

Inspect .github/workflows/test-cedarling.yml and compare its Rust declarations with jans-cedarling/rust-toolchain.toml. Search the workflow for toolchain: stable, cargo +stable, and rustup component add --toolchain stable, then verify every Cedarling job uses 1.95.0 consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, rust
Domain
ci-cd
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.