JanWielgus / JanWielgus/StateDesignPatternLib

Context don't have to be passed in setState method

Open
#1 0 comments 0 reactions 0 assignees View on GitHub
bug enhancement good first issue invalid
Dominant language
C++
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Currently `setState` method (that is run from context object) have a first argument of context. This context is the same object for which we run this method, so in this method it could be accessed by `this` pointer. Using this method with different context than for which it is executed will be invalid, so it is also a bug.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the setState declaration and implementation, then inspect its callers to confirm how the context argument is currently passed. Update the API consistently and verify that existing usage still compiles and uses the owning context; the issue is done when the redundant argument is no longer required.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.