JamieMason / JamieMason/peach.js

Handle iterators containing return statements

Open
#6 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
4
Forks
0
PR merge metrics
No merged PRs in 30d

Description

From @jdalton's comment at jsperf.com

Compiling won't work on iterators that contain a return statement because they will compile to exiting out of the while loop.

Using return in an iterator supplied to _.each() is equivalent to continue in a loop.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the iterator compilation path described in the issue and compare how return statements are emitted with the behavior expected inside _.each(). Use the linked jsperf comment as context for the intended semantics. Done means a return in an iterator behaves like continue rather than exiting the generated while loop, with coverage for that case.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.