JakeWharton / JakeWharton/timber

WrongTimberUsageDetector.checkNestedStringFormat NPE

Open
#334 4 comments 3 reactions 1 assignee Claimed by @jrodbx View on GitHub
Dominant language
Kotlin
Stars
10.8k
Forks
994
Avg merge
17h 16m
Merged PRs (30d)
17

Description

Hi! We use latest Timber version(4.7.1). I found some issue in custom Lint rule(WrongTimberUsageDetector). Did not go deeper to find reason, why it is crashing. Just post you simple code, that initiates NPE.

_Code:_
`TextUtils.join(",", Arrays.asList(String.format("Hello %s", "World"), "Hello World"));`

_Crash log:_
```
NullPointerException:
WrongTimberUsageDetector.checkNestedStringFormat(WrongTimberUsageDetector.java:111)?
WrongTimberUsageDetector.visitMethod(WrongTimberUsageDetector.java:74)?
UElementVisitor$DelegatingPsiVisitor.visitMethodCallExpression(UElementVisitor.kt:1027)?UElementVisitor$DelegatingPsiVisitor.visitCallExpression(UElementVisitor.kt:1007)?
UCallExpression$DefaultImpls.accept(UCallExpression.kt:99)?
JavaUCallExpression.accept(javaUCallExpressions.kt:24)?
UQualifiedReferenceExpression$DefaultImpls.accept(UQualifiedReferenceExpression.kt:48)?
JavaUCompositeQualifiedExpression.accept(JavaUCompositeQualifiedExpression.kt:22)
```

Hope, this info will be helpful for you to find solve,

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.