JakeWharton / JakeWharton/timber

Timber lint check warns on compile time constants

Open
#116 0 comments 12 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
10.9k
Forks
994
Avg merge
17h 16m
Merged PRs (30d)
17

Description

Given this code:

```
Timber.e("this is a really not multiline string"
+ "broken up for clarity")
```

_Actual_
Lint warns about using Timber's built in formatting.
![image](https://cloud.githubusercontent.com/assets/1195562/11961840/a2897c84-a898-11e5-852f-e5efaeee8da4.png)

_Desired_
Lint should not warn on compile time constants.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the lint check responsible for Timber's built-in formatting warning and reproduce the issue with the compile-time string concatenation shown here. Add a regression test for that example and verify that the warning is no longer emitted while non-constant formatting cases retain their existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
40/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.