JakeWharton / JakeWharton/picnic

Characters don't work on Windows

Open
#29 6 comments 1 reaction 0 assignees View on GitHub
Dominant language
Kotlin
Stars
975
Forks
34
Avg merge
3h 23m
Merged PRs (30d)
13

Description

It appears that the unicode characters are not generated or recognized correctly on Windows.

I've opened a PR to add a GitHub action to build on Windows, Linux and Mac; the Windows build always fails, though, because the tables look like this:

? compressed ? uncompressed
?????????????????????????????????????????????????????????????????
APK ? old ? new ? diff ? old ? new ? diff
???????????????????????????????????????????????????????????????????????????
dex ? 664.8 KiB ? 664.8 KiB ? -25 B ? 1.5 MiB ? 1.5 MiB ? -112 B
arsc ? 201.7 KiB ? 201.7 KiB ? 0 B ? 201.6 KiB ? 201.6 KiB ? 0 B
manifest ? 1.4 KiB ? 1.4 KiB ? 0 B ? 4.2 KiB ? 4.2 KiB ? 0 B
res ? 418.2 KiB ? 418.2 KiB ? -14 B ? 488.3 KiB ? 488.3 KiB ? 0 B
asset ? 0 B ? 0 B ? 0 B ? 0 B ? 0 B ? 0 B
other ? 37.1 KiB ? 37.1 KiB ? 0 B ? 36.3 KiB ? 36.3 KiB ? 0 B
???????????????????????????????????????????????????????????????????????????

See build results [here](https://github.com/garfieldnate/picnic/runs/2332380431?check_suite_focus=true).

Contributor guide

No contributing guide indexed for this repository

Research direction

No source file or test is named in the issue. Start by reproducing the Windows build from the linked GitHub Actions results and compare its table output with Linux and macOS; done means Unicode table characters are generated and recognized correctly and the Windows build passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.