JakeWharton / JakeWharton/diffuse

Bytecode version diff should use a different rendering

Open
#490 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
2.2k
Forks
118
Avg merge
2h 18m
Merged PRs (30d)
19

Description

Today we're using a common diff helper, but it doesn't serve the content well.

```
BYTECODE VERSIONS:

old │ new │ diff
─────┼─────┼───────────
1 │ 1 │ 0 (+1 -1)

+ org.example.MainKt: 65

- org.example.MainKt: 69
```

It should probably be something like

```
BYTECODE VERSIONS:

version │ old │ new │ diff
─────────┼─────┼───────────
65 │ 256 │ 255 │ -1 (0 -1)
69 │ 0 │ 1 │ +1 (+1 0)

org.example.MainKt: 65 → 69
```

Not sure whether we should show new types and their versions here. Maybe we combine with the types output?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the bytecode version output and the common diff helper used to render it. Update the rendering to present version, old, new, and diff columns with the class version transition, and resolve whether new types and their versions belong in this output or the types output.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.