JakeChampion / JakeChampion/trafficserver

[10.2][hdrs] URL authority parser accepts non-digit trailing characters in port

Open
#85 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

10.2 area:hdrs audit severity:medium
Dominant language
C++
Stars
0
Forks
0
Avg merge
8h 2m
Merged PRs (30d)
21

Description

Branch: 10.2.x (10.2.1, commit 31f1f2f3b) · Severity: medium · category: logic-bug
Location: src/proxy/hdrs/URL.cc:479 (parse), port extraction at :1376-1383

What's wrong

url_parse_internet() extracts the port substring as everything between the last colon and the authority terminator (/, ?, #, or EOS) without validating it is all digits, and never runs it through the digit-strict validation used for the Host header. A port like 8080abc is accepted; the numeric port and the stored port text can then disagree, which is a cache-key / routing consistency hazard and a parser-differential risk versus stricter upstreams.

Suggested fix

Validate the port TextView is non-empty and all digits in url_parse_internet() (mirroring http_parse_host_header) and return ParseResult::ERROR otherwise; or reject in set_port().

Why tracked, not yet a PR

This tightens URL parsing acceptance, which can affect existing autests and real traffic patterns; it should land with the end-to-end autest suite run (not available in the audit environment). Filing for a maintainer to apply with proper test coverage.


From an automated multi-lens audit of the 10.2.x branch. Full report on branch claude/codebase-audit-review-9nw7vz (CODEBASE_AUDIT_10.2.md).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/proxy/hdrs/URL.cc at url_parse_internet() around line 479 and compare its port extraction with the digit-strict validation in http_parse_host_header around lines 1376-1383. Confirm that malformed ports are rejected with ParseResult::ERROR, add or update focused coverage, and run the end-to-end autest suite to verify the parser change.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.