JSONAPI-Resources / JSONAPI-Resources/jsonapi-resources

include has_one relationships to avoid n+1 query when always_include_to_one_linkage_data is true

Open
#543 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Type: Bug
Dominant language
Ruby
Stars
2.3k
Forks
546
PR merge metrics
No merged PRs in 30d

Description

If always_include_to_one_linkage_data is true, we should include the has_one relationships in the query to avoid n+1 database requests.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the handling of always_include_to_one_linkage_data and the query construction for has_one relationships. Verify how related records are loaded, then add coverage showing that enabled linkage data avoids N+1 database requests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rails, ruby
Domain
backend, database
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.