JSONAPI-Resources / JSONAPI-Resources/jsonapi-resources

Why does immutable only apply to `jsonapi_resources` and not `jsonapi_resource`?

Open
#520 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Type: Enhancement
Dominant language
Ruby
Stars
2.3k
Forks
546
PR merge metrics
No merged PRs in 30d

Description

It looks like the immutable method is only applied to resources when using the jsonapi_resources method for routing. The immutable method has no effect on resources created with the jsonapi_resource method. Why is this the case?

If I have a resource that isn't queried by id, then can't it also be immutable?

Reference: https://github.com/cerebris/jsonapi-resources/blob/858fdd13515cc4f637d2cb26b7e4be7fb9ed780e/lib/jsonapi/routing_ext.rb#L83

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with lib/jsonapi/routing_ext.rb at the referenced line and compare how immutable is applied by jsonapi_resources versus jsonapi_resource. Determine whether the difference is intentional for resources not queried by id, then document the expected behavior and verify the routing cases involved.

Written by the indexing model from the issue text.

Assessment

Tech stack
rails, ruby
Domain
api, backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.